[svn] 3341: Changing the definition of some methods in SkinnableComponent.
revision: 3341
author: rfrishbe@adobe.com
date: 2008-09-24 16:10:20 -0700 (wed, 24 sep 2008)
log message:
-----------
changing definition of methods in skinnablecomponent. instead of:
protected function partadded(partname:string, instance:*):void
we have:
protected function partadded(partname:string, instance:object):void
technically means can't support value of "undefined" anymore. change made partadded(), partremoved(), createpartinstance(), removepartinstance(), , getdyanamicpartat().
as making these changes in files override these methods, noticed slider should have partremoved() method, added it.
i made minor change in selector there bug in dataprovider collectionchange eventhandler. doing remove code on replace rather remove.
qe: yes - break (as in, won't compile) tests in skinnablecomponent. joann change them after checkin.
doc: yes
bugs: sdk-16640, sdk-16709
reviewer: hans
ticket links:
------------
http://bugs.adobe.com/jira/browse/sdk-16640
http://bugs.adobe.com/jira/browse/sdk-16709
modified paths:
--------------
flex/sdk/trunk/frameworks/projects/flex4/src/flex/component/datacomponent.as
flex/sdk/trunk/frameworks/projects/flex4/src/flex/component/itemscomponent.as
flex/sdk/trunk/frameworks/projects/flex4/src/flex/component/list.as
flex/sdk/trunk/frameworks/projects/flex4/src/flex/component/numericstepper.as
flex/sdk/trunk/frameworks/projects/flex4/src/flex/component/scrollbar.as
flex/sdk/trunk/frameworks/projects/flex4/src/flex/component/scroller.as
flex/sdk/trunk/frameworks/projects/flex4/src/flex/component/selector.as
flex/sdk/trunk/frameworks/projects/flex4/src/flex/component/slider.as
flex/sdk/trunk/frameworks/projects/flex4/src/flex/component/spinner.as
flex/sdk/trunk/frameworks/projects/flex4/src/flex/component/textarea.as
flex/sdk/trunk/frameworks/projects/flex4/src/flex/component/textbase.as
flex/sdk/trunk/frameworks/projects/flex4/src/flex/component/textinput.as
flex/sdk/trunk/frameworks/projects/flex4/src/flex/component/trackbase.as
flex/sdk/trunk/frameworks/projects/flex4/src/flex/core/skinnablecomponent.as
author: rfrishbe@adobe.com
date: 2008-09-24 16:10:20 -0700 (wed, 24 sep 2008)
log message:
-----------
changing definition of methods in skinnablecomponent. instead of:
protected function partadded(partname:string, instance:*):void
we have:
protected function partadded(partname:string, instance:object):void
technically means can't support value of "undefined" anymore. change made partadded(), partremoved(), createpartinstance(), removepartinstance(), , getdyanamicpartat().
as making these changes in files override these methods, noticed slider should have partremoved() method, added it.
i made minor change in selector there bug in dataprovider collectionchange eventhandler. doing remove code on replace rather remove.
qe: yes - break (as in, won't compile) tests in skinnablecomponent. joann change them after checkin.
doc: yes
bugs: sdk-16640, sdk-16709
reviewer: hans
ticket links:
------------
http://bugs.adobe.com/jira/browse/sdk-16640
http://bugs.adobe.com/jira/browse/sdk-16709
modified paths:
--------------
flex/sdk/trunk/frameworks/projects/flex4/src/flex/component/datacomponent.as
flex/sdk/trunk/frameworks/projects/flex4/src/flex/component/itemscomponent.as
flex/sdk/trunk/frameworks/projects/flex4/src/flex/component/list.as
flex/sdk/trunk/frameworks/projects/flex4/src/flex/component/numericstepper.as
flex/sdk/trunk/frameworks/projects/flex4/src/flex/component/scrollbar.as
flex/sdk/trunk/frameworks/projects/flex4/src/flex/component/scroller.as
flex/sdk/trunk/frameworks/projects/flex4/src/flex/component/selector.as
flex/sdk/trunk/frameworks/projects/flex4/src/flex/component/slider.as
flex/sdk/trunk/frameworks/projects/flex4/src/flex/component/spinner.as
flex/sdk/trunk/frameworks/projects/flex4/src/flex/component/textarea.as
flex/sdk/trunk/frameworks/projects/flex4/src/flex/component/textbase.as
flex/sdk/trunk/frameworks/projects/flex4/src/flex/component/textinput.as
flex/sdk/trunk/frameworks/projects/flex4/src/flex/component/trackbase.as
flex/sdk/trunk/frameworks/projects/flex4/src/flex/core/skinnablecomponent.as
More discussions in Commits
adobe
Comments
Post a Comment